Re: [PATCH] Support tags in uncommit - use git_id instead of rev_parse

From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Oct 3, 2007, 20:35 UTC
Message-ID: <b0943d9e0710031335o1c7f3a10i6f2055b76376bfd4@mail.gmail.com>
In-Reply-To: <1191362591.26879.3.camel@dv>

On 02/10/2007, Pavel Roskin <proski@gnu.org> wrote:

Show 12 quoted lines

> On Mon, 2007-10-01 at 23:00 +0100, Catalin Marinas wrote:
> > To allow tags, maybe just pass something like
> > "git.rev_parse(options.to + '^{commit}')" or just modify git.rev_parse
> > to do it (and git_id to avoid it).
>
> I prefer to work with software that understands what I mean and tells me
> that I cannot do it.  It makes it easier to understand what is possible
> and how the command is working.
>
> Recognizing patch names in some commands but not others would be
> annoying and inconsistent.  Dumbing downs interactive software on
> purpose is probably not worth the trouble.

Without this patch, the 'stg uncommit -t patch' fails with 'Unknown revision: patch'. With the patch applied, it still fails but with 'Commit ... does not have exactly one parent'. I don't say that the first one is good but I don't think the latter is clearer. The 'stg uncommit --help' states that the '--to' option takes a commit argument but if one passes a patch name the error message gets pretty confusing.

-- 
Catalin