Re: [PATCH] Support tags in uncommit - use git_id instead of rev_parse

From: Pavel Roskin <proski@gnu.org>
Date: Oct 2, 2007, 22:03 UTC
Message-ID: <1191362591.26879.3.camel@dv>
In-Reply-To: <b0943d9e0710011500o1bd621a4q10dfe0468c8795e2@mail.gmail.com>

On Mon, 2007-10-01 at 23:00 +0100, Catalin Marinas wrote:

Show 5 quoted lines

> On 30/09/2007, Pavel Roskin <proski@gnu.org> wrote:
> > Signed-off-by: Pavel Roskin <proski@gnu.org>
> 
> With this patch, uncommit can take patch names (with modifiers) as the
> --to argument. When would this be needed?

Probably never.

> To allow tags, maybe just pass something like
> "git.rev_parse(options.to + '^{commit}')" or just modify git.rev_parse
> to do it (and git_id to avoid it).

I prefer to work with software that understands what I mean and tells me that I cannot do it. It makes it easier to understand what is possible and how the command is working.

Recognizing patch names in some commands but not others would be annoying and inconsistent. Dumbing downs interactive software on purpose is probably not worth the trouble.

-- 
Regards,
Pavel Roskin