git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGIT PATCH 0/2] Fix issues with series deletion

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Jun 7, 2007, 21:50 UTC
Message-ID
<b0943d9e0706071450u1587d109x1e592bfa453c0c0@mail.gmail.com>
In-Reply-To
<20070606205852.7657.69286.stgit@gandelf.nowhere.earth>
On 06/06/07, Yann Dirson <ydirson@altern.org> wrote:
Show 8 quoted lines
> I am however not happy at all with the way we delete patches and
> series, starting with an existence check and then deleting.  If any
> error occurs midway, then we are left with an inconsistent state that
> the user has to cleanup by hand.  IMHO, we should have those methods
> be as robust as possible, maybe starting by removing the formatversion
> item, and printing a "cleaning up zombie stack" if does not find it.
> So at least after fixing a "delete" bug, we could rerun the same
> command and get to a sane state again.

This sounds OK for a quick fix. Longer term, I think we should support some kind of transactions. One idea is to put the StGIT metadata in a single file (or maybe two if we include the config) that gets checked in after every operation.

-- 
Catalin
Previous: Yann DirsonNext: Yann Dirson
Message 4 of 6 in “Fix issues with series deletion”
  1. 0/2 Fix issues with series deletionYann Dirson, Jun 6, 2007
  2. 1/2 Fix removal of series with non-existant trash dir.Yann Dirson, Jun 6, 2007
  3. 2/2 Fix removal of series to nuke the formatversion config item.Yann Dirson, Jun 6, 2007
  4. Catalin MarinasJun 7, 2007
  5. Yann DirsonJun 9, 2007
  6. Catalin MarinasJun 12, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.