Re: [StGIT PATCH 0/2] Fix issues with series deletion

From: Yann Dirson <ydirson@altern.org>
Date: Jun 9, 2007, 18:43 UTC
Message-ID: <20070609184317.GM6992@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <b0943d9e0706071450u1587d109x1e592bfa453c0c0@mail.gmail.com>

On Thu, Jun 07, 2007 at 10:50:00PM +0100, Catalin Marinas wrote:

Show 14 quoted lines

> On 06/06/07, Yann Dirson <ydirson@altern.org> wrote:
> >I am however not happy at all with the way we delete patches and
> >series, starting with an existence check and then deleting.  If any
> >error occurs midway, then we are left with an inconsistent state that
> >the user has to cleanup by hand.  IMHO, we should have those methods
> >be as robust as possible, maybe starting by removing the formatversion
> >item, and printing a "cleaning up zombie stack" if does not find it.
> >So at least after fixing a "delete" bug, we could rerun the same
> >command and get to a sane state again.
> 
> This sounds OK for a quick fix. Longer term, I think we should support
> some kind of transactions. One idea is to put the StGIT metadata in a
> single file (or maybe two if we include the config) that gets checked
> in after every operation.

Speaking of transactions, did you have a chance to read the proposal I posted some time ago ? As stated in another mail, I fear that approach does generalize easily to core git - but for lack of a better solution, we may want to go this way anyway...

Best regards,

-- 
Yann