git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Factorize editor handling.

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Feb 27, 2007, 14:17 UTC
Message-ID
<b0943d9e0702270617h6ba8669bke55182f84296064b@mail.gmail.com>
In-Reply-To
<20070226194812.28907.80551.stgit@gandelf.nowhere.earth>
On 26/02/07, Yann Dirson <ydirson@altern.org> wrote:
> At the same time we trap the editor error for all editor calls, not
> just when called from "stg mail".

I merged this patch. In the initial StGIT versions, someone complained that an editor (ed) returning a non-zero code is not actually an error and shouldn't raise an exception. If anyone complains about this in the future (that person is no longer using StGIT :-)), we could add a config option to not raise the exception (though with some problems for them).

> We may want to define a new exception for this though.

I added an EditorException since it needs to cought in main.py to avoid a stack dump.

-- 
Catalin
Previous: Yann Dirson
Message 2 of 2 in “Factorize editor handling.”
  1. Factorize editor handling.Yann Dirson, Feb 26, 2007
  2. Catalin MarinasFeb 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.