From: Catalin Marinas <catalin.marinas@gmail.com>
Date: Tue, 27 Feb 2007 14:17:34 GMT
Subject: Re: [PATCH] Factorize editor handling.
Message-ID: <b0943d9e0702270617h6ba8669bke55182f84296064b@mail.gmail.com>
In-Reply-To: <20070226194812.28907.80551.stgit@gandelf.nowhere.earth>

On 26/02/07, Yann Dirson <ydirson@altern.org> wrote:
> At the same time we trap the editor error for all editor calls, not
> just when called from "stg mail".

I merged this patch. In the initial StGIT versions, someone complained
that an editor (ed) returning a non-zero code is not actually an error
and shouldn't raise an exception. If anyone complains about this in
the future (that person is no longer using StGIT :-)), we could add a
config option to not raise the exception (though with some problems
for them).

> We may want to define a new exception for this though.

I added an EditorException since it needs to cought in main.py to
avoid a stack dump.

-- 
Catalin