git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Don't require config file for "stg mail"

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
Nov 29, 2006, 16:29 UTC
Message-ID
<b0943d9e0611290829h291942d7x13247511d16afeee@mail.gmail.com>
In-Reply-To
<20061129035930.6118.88435.stgit@dv.roinet.com>
On 29/11/06, Pavel Roskin <proski@gnu.org> wrote:
> When calculating the string to be used in the From: field, don't require
> it to come from the configuration file.  Instead, reuse already known
> authname and authemail values as the default.  They can be taken from
> the GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL environment variables.

Your patch uses the author of the patch which can be different from the person sending the e-mail. It could indeed use the author from GIT variables or configuration (not the patch author) and I already have a patch from Karl Hasselström for this (which I haven't found the time to check properly).

The reason I added a sender option is because the sender (that gets added to the e-mail headers) may differ from the author of the patch. I use one e-mail address as the author but I might be behind an SMTP server which only allows a different e-mail address and therefore I set the sender accordingly.

Once I merge Karl's patch, I'll modify StGIT to use the GIT defaults if there is no sender configured.

Previous: Pavel RoskinNext: Pavel Roskin
Message 3 of 5 in “Set HOME to the test directory to avoid reading ~/.stgitrc”
  1. 1/2 Set HOME to the test directory to avoid reading ~/.stgitrcPavel Roskin, Nov 29, 2006
  2. 2/2 Don't require config file for "stg mail"Pavel Roskin, Nov 29, 2006
  3. Catalin MarinasNov 29, 2006
  4. Pavel RoskinNov 29, 2006
  5. Catalin MarinasNov 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.