git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Don't require config file for "stg mail"

From
PRPavel Roskin <proski@gnu.org>
Date
Nov 29, 2006, 23:27 UTC
Message-ID
<1164842841.23643.28.camel@dv>
In-Reply-To
<b0943d9e0611290829h291942d7x13247511d16afeee@mail.gmail.com>
Hello, Catalin!
On Wed, 2006-11-29 at 16:29 +0000, Catalin Marinas wrote:
Show 11 quoted lines
> On 29/11/06, Pavel Roskin <proski@gnu.org> wrote:
> > When calculating the string to be used in the From: field, don't require
> > it to come from the configuration file.  Instead, reuse already known
> > authname and authemail values as the default.  They can be taken from
> > the GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL environment variables.
> 
> Your patch uses the author of the patch which can be different from
> the person sending the e-mail. It could indeed use the author from GIT
> variables or configuration (not the patch author) and I already have a
> patch from Karl Hasselström for this (which I haven't found the time
> to check properly).

The funny thing it, GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL are only used in the code to determine the author of the patch.

Apparently, things are more twisted than I expected, so they need some untangling first.

> Once I merge Karl's patch, I'll modify StGIT to use the GIT defaults
> if there is no sender configured.
Sounds good.
-- 
Regards,
Pavel Roskin
Previous: Catalin MarinasNext: Catalin Marinas
Message 4 of 5 in “Set HOME to the test directory to avoid reading ~/.stgitrc”
  1. 1/2 Set HOME to the test directory to avoid reading ~/.stgitrcPavel Roskin, Nov 29, 2006
  2. 2/2 Don't require config file for "stg mail"Pavel Roskin, Nov 29, 2006
  3. Catalin MarinasNov 29, 2006
  4. Pavel RoskinNov 29, 2006
  5. Catalin MarinasNov 30, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.