git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Handle branch names with slashes

From
CMCatalin Marinas <catalin.marinas@gmail.com>
Date
May 17, 2006, 15:18 UTC
Message-ID
<b0943d9e0605170818j380a6daaif42f2acbf627104f@mail.gmail.com>
In-Reply-To
<20060516074504.GA27234@diana.vm.bytemark.co.uk>
On 16/05/06, Karl Hasselström <kha@treskal.com> wrote:
Show 18 quoted lines
> On 2006-05-15 23:48:04 -0700, Junio C Hamano wrote:
>
> > Karl Hasselström <kha@treskal.com> writes:
> >
> > > I had to change the patch@branch/top command-line syntax to
> > > patch@branch%top, in order to get sane parsing. The /top variant
> > > is still available for repositories that have no slashy branches;
> > > it is disabled as soon as there exists at least one subdirectory
> > > of refs/heads. Preferably, this compatibility hack can be killed
> > > some time in the future.
> >
> > I wonder if using double-slashes is an easier alternative to type
> > than '%', like "patch@branch//top". That way, you do not have to
> > forbid per-cent sign in branch names.
>
> Good argument. And // does look slightly better than %, too. But I'll
> wait a few days this time, or else someone will surely come along with
> an even better idea. :-)
I also thing // is a better solution than %.

There is another option, a bit more complicated, "patch@branch:top". This would imply replacing : with .. in the current handling of the -r option in diff/mail/export but it would make the commit or patch ranges look more like GIT's arguments.

-- 
Catalin
Previous: Karl HasselströmNext: Karl Hasselström
Message 8 of 15 in “Don't die when there are no branches”
  1. 1/3 Don't die when there are no branchesKarl Hasselström, May 15, 2006
  2. 2/3 Handle branch names with slashesKarl Hasselström, May 15, 2006
  3. Catalin MarinasMay 15, 2006
  4. Karl HasselströmMay 15, 2006
  5. 1/2 Handle branch names with slashesKarl Hasselström, May 16, 2006
  6. Junio C HamanoMay 16, 2006
  7. Karl HasselströmMay 16, 2006
  8. Catalin MarinasMay 17, 2006
  9. 1/2 Handle branch names with slashesKarl Hasselström, May 18, 2006
  10. Handle branch names with slashesKarl Hasselström, May 18, 2006
  11. Catalin MarinasMay 18, 2006
  12. Karl HasselströmMay 18, 2006
  13. 2/2 Tests for branch names with slashesKarl Hasselström, May 18, 2006
  14. 2/2 Tests for branch names with slashesKarl Hasselström, May 16, 2006
  15. 3/3 Tests for branch names with slashesKarl Hasselström, May 15, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.