Re: [PATCH 1/2] Handle branch names with slashes

From: Karl Hasselström <kha@treskal.com>
Date: May 16, 2006, 07:45 UTC
Message-ID: <20060516074504.GA27234@diana.vm.bytemark.co.uk>
In-Reply-To: <7v64k6ea8r.fsf@assigned-by-dhcp.cox.net>

On 2006-05-15 23:48:04 -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Karl Hasselström <kha@treskal.com> writes:
>
> > I had to change the patch@branch/top command-line syntax to
> > patch@branch%top, in order to get sane parsing. The /top variant
> > is still available for repositories that have no slashy branches;
> > it is disabled as soon as there exists at least one subdirectory
> > of refs/heads. Preferably, this compatibility hack can be killed
> > some time in the future.
>
> I wonder if using double-slashes is an easier alternative to type
> than '%', like "patch@branch//top". That way, you do not have to
> forbid per-cent sign in branch names.

Good argument. And // does look slightly better than %, too. But I'll wait a few days this time, or else someone will surely come along with an even better idea. :-)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle