Re: [PATCH 3/6] t/perf: add infrastructure for measuring sizes

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 22, 2018, 13:40 UTC
Message-ID: <b071f6a2-2403-0bbb-72a5-695f8c4e724d@gmail.com>
In-Reply-To: <20180821190654.GC30764@sigill.intra.peff.net>

On 8/21/2018 3:06 PM, Jeff King wrote:

Show 8 quoted lines

> The main objective of scripts in the perf framework is to
> run "test_perf", which measures the time it takes to run
> some operation. However, it can also be interesting to see
> the change in the output size of certain operations.
>
> This patch introduces test_size, which records a single
> numeric output from the test and shows it in the aggregated
> output (with pretty printing and relative size comparison).

I'm interested in exploring this test_size mechanism. The other area that could benefit from size testing is 'git repack', but I don't have any plans to change our compression or delta strategies. If we _did_ look into that, then using test_size would be a natural fit.

Overall, I really like this series!

Thanks -Stolee