Re: [PATCH 0/4] un-breaking pack-objects with bitmaps

From: Jeff King <peff@peff.net>
Date: Sep 4, 2018, 20:03 UTC
Message-ID: <20180904200342.GC17481@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kZtXOmKo-86x=x4Z+tA0uiSmy4ntX+U4aCUYSjy4_DVDw@mail.gmail.com>

On Tue, Sep 04, 2018 at 12:30:14PM -0700, Stefan Beller wrote:

Show 23 quoted lines

> >   [1/4]: bitmap_has_sha1_in_uninteresting(): drop BUG check
> >
> >     The actual fix. This should get merged to next ASAP (or the original
> >     topic just reverted).
> >
> >   [2/4]: t5310: test delta reuse with bitmaps
> >
> >     I did this separately to give us flexibility to squash or merge
> >     quickly. But it does find Ævar's bug on a git without patch 1.
> >
> >   [3/4]: traverse_bitmap_commit_list(): don't free result
> >
> >     The original assert should have simply been useless, but it was the
> >     surprising behavior of this function that turned it into a bug.
> >
> >   [4/4]: pack-bitmap: drop "loaded" flag
> >
> >     And this is just an annoyance I ran into, which is a fallout from
> >     our conversion to using an allocated bitmap_index struct.
> 
> FWIW, the whole series is
> Reviewed-by: Stefan Beller <sbeller@google.com>
> I am sorry for suggesting the BUG() in the first place.

Heh. You only asked a question about the interface. I was the one who was _supposed_ to be familiar with the code, and put in the actual assertion. So if your suggestion was dumb, my response was doubly so. :)

-Peff