git/list[1] front-page[2] threads[3] people[4] search[5] about
 

submodule: linked-worktree submodule hits BUG() in validate_submodule_legacy_git_dir()

From
AWAndreas Wendleder <gonsolo@gmail.com>
Date
Nov 16, 2026, 22:51 UTC
Message-ID
<avuJBGlB3pRU3JU0@pampelmuse>

With submodule.recurse=true, switching branches in a superproject worktree whose submodule is itself a linked worktree of the submodule repository aborts:

  BUG: submodule.c:2414: submodule name 'sub' not a suffix of git dir
  '.../.git/modules/sub/worktrees/sub1'
Reproduction (git 2.56.0; the code is the same on master, next and seen):
  #!/bin/sh
  set -e
  export GIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_NOSYSTEM=1
  g() { git -c user.name=t -c user.email=t@t -c protocol.file.allow=always "$@"; }
  rm -rf w && mkdir w && cd w
  g init -q -b main sub && g -C sub commit -q --allow-empty -m s1
  g init -q -b main super && cd super
  g submodule add -q ../sub sub && g commit -q -m add
  g -C sub commit -q --allow-empty -m s2 && g add sub && g commit -q -m bump
  g branch other HEAD~1
  g worktree add -q --detach ../wt main
  g -C sub worktree add -q --detach ../../other/sub HEAD  # takes the name 'sub'
  g -C sub worktree add -q --detach ../../wt/sub HEAD     # so this one is 'sub1'
  cd ../wt
  g -c submodule.recurse=true switch other

submodule_move_head() expects validate_submodule_git_dir() to return < 0 and then dies with "refusing to create/use ... Enabling extensions.submodulePathConfig should fix this", but without the extension validate_submodule_legacy_git_dir() calls BUG() instead. A linked worktree's git dir (modules/<name>/worktrees/<id>) never ends in the submodule name, so this setup always hits it.

With extensions.submodulePathConfig enabled (repositoryformatversion 1), the same commands no longer crash but die with the "refusing to create/use ..." message, which recommends enabling the extension that is already enabled.

I would expect a linked worktree of a submodule's repository to be accepted as the submodule's git dir. If it is meant to be rejected, the legacy path should return an error instead of calling BUG(), and the hint should not suggest the extension when it is already on.

Next: Adrian Ratiu
Message 1 of 2 in “submodule: linked-worktree submodule hits BUG() in validate_submodule_legacy_git_dir()”
  1. Andreas WendlederNov 16, 2026
  2. Adrian RatiuNov 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.