git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: submodule: linked-worktree submodule hits BUG() in validate_submodule_legacy_git_dir()

From
Adrian Ratiu <adrian.ratiu@collabora.com>
Date
Nov 17, 2026, 17:45 UTC
Message-ID
<877bibjqrv.fsf@collabora.com>
In-Reply-To
<avuJBGlB3pRU3JU0@pampelmuse>
Hi Andreas,
On Mon, 16 Nov 2026, Andreas Wendleder <gonsolo@gmail.com> wrote:
Show 6 quoted lines
> With submodule.recurse=true, switching branches in a superproject worktree
> whose submodule is itself a linked worktree of the submodule repository
> aborts:
>
>   BUG: submodule.c:2414: submodule name 'sub' not a suffix of git dir
>   '.../.git/modules/sub/worktrees/sub1'
Thanks for reporting this and for the reproducer.

The BUG() is older than submodulePathConfig. Users could not reach it before 9cf8547320 (clone: prevent clashing git dirs when cloning submodule in parallel, 2024-01-28), which made submodule_move_head() validate whatever path the submodule's gitfile points to. A path read from disk can be anything, so it should never hit a BUG().

Your reproducer needs the second worktree because the gitdir ".../sub" happens to end in the submodule name, so the check passes by accident.

t2405 sets up exactly this layout but never runs a recursvie checkout.
I'll send a fix.
Show 9 quoted lines
> With extensions.submodulePathConfig enabled (repositoryformatversion 1),
> the same commands no longer crash but die with the "refusing to create/use
> ..." message, which recommends enabling the extension that is already
> enabled.
>
> I would expect a linked worktree of a submodule's repository to be
> accepted as the submodule's git dir. If it is meant to be rejected, the
> legacy path should return an error instead of calling BUG(), and the hint
> should not suggest the extension when it is already on.
Yes, the hint is actually my mistake.

I have a local fix which I need to test a bit more, but makes your script switch cleanly in both modes and the main submodule checkout isn't touched.

Will send it in the next few days with you in Reported-by.

Thanks again, Adrian

Previous: Andreas Wendleder
Message 2 of 2 in “submodule: linked-worktree submodule hits BUG() in validate_submodule_legacy_git_dir()”
  1. Andreas WendlederNov 16, 2026
  2. Adrian RatiuNov 17, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.