git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] log: make --follow following renames for non-linear history optional

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 16, 2026, 08:01 UTC
Message-ID
<avq4QewLSGVLkCjv@pks.im>
In-Reply-To
<avqyVuMvKeQshZYS@collabora.com>

On Mon, Nov 16, 2026 at 08:35:50AM +0100, Miklos Vajna wrote: [snip]

Show 12 quoted lines
> > > +	if (opt->diffopt.flags.follow_renames &&
> > > +	    opt->diffopt.flags.follow_merges) {
> ...
> > As far as I've seen we only ever set `follow_merges` when
> > `follow_renames = 1`, so it feels redundant to check for both. But on
> > the other hand that's a bit more defensive, so maybe that's not a bad
> > idea.
> 
> My thinking was that follow_merges is a modifier of follow_renames. If
> some code path clears follow_renames later (like builtin/blame.c does)
> without knowing about follow_merges, checking both flags means that we
> still skip the per-parent rename diffs. So I would keep it as-is.
Makes sense.

One hint: please reply to review feedback on the mail that gave the feedback instead of posting it as part of v2. That makes it easier for others to see which review feedback was addressed.

Show 12 quoted lines
> Range-diff against v1:
> 1:  cdf63f7017 ! 1:  cd19ed03cc log: make --follow following renames for non-linear history optional
>     @@ Documentation/config/log.adoc: This is the same as the `--decorate` option of th
>      -	i.e. it cannot be used to follow multiple files.
>      +	i.e. it cannot be used to follow multiple files and does not work well
>      +	on non-linear history.  If `merges`, `git log` will act as if the
>     -+	`--follow=merges` option was used.
>     ++	`--follow=merges` option was used, which follows the path separately
>     ++	for each parent of a merge, but is more expensive.
>       
>       `log.graphColors`::
>       	A list of colors, separated by commas, that can be used to draw

Good, this gives the user the necessary context to decide why they may or may not want to enable this config.

Show 14 quoted lines
>     @@ builtin/log.c: static int git_log_config(const char *var, const char *value,
>       	}
>       	if (!strcmp(var, "log.follow")) {
>      -		cfg->default_follow = git_config_bool(var, value);
>     -+		if (value && !strcmp(value, "merges"))
>     ++		int b = git_parse_maybe_bool(value);
>     ++		if (b >= 0)
>     ++			cfg->default_follow = b;
>     ++		else if (!strcmp(value, "merges"))
>      +			cfg->default_follow = 2;
>      +		else
>     -+			cfg->default_follow = git_config_bool(var, value);
>     ++			return error(_("invalid value for '%s': '%s'"),
>     ++				     var, value);

And this fixes the broken error message when an invalid value was passed.

Thanks, this version looks good to me.
Patrick
Previous: Miklos VajnaNext: Junio C Hamano
Message 43 of 48 in “Performance regression in `git log --follow`”
  1. Patrick SteinhardtOct 13, 2026
  2. SZEDER GáborOct 13, 2026
  3. log: speed up --follow following renames for non-linear historyMiklos Vajna, Oct 15, 2026
  4. Junio C HamanoOct 15, 2026
  5. log: speed up --follow following renames for non-linear historyMiklos Vajna, Oct 19, 2026
  6. 0/4 log: speed up --follow following renames for non-linear historyMiklos Vajna, Oct 22, 2026
  7. 1/4 t4219: test more --follow cases across mergesMiklos Vajna, Oct 22, 2026
  8. 2/4 log: extract showing the remerge/combined diff of a merge commitMiklos Vajna, Oct 22, 2026
  9. 3/4 log: simplify --follow following renames for non-linear historyMiklos Vajna, Oct 22, 2026
  10. Patrick SteinhardtOct 26, 2026
  11. 4/4 log: speed up --follow following renames for non-linear historyMiklos Vajna, Oct 22, 2026
  12. Patrick SteinhardtOct 26, 2026
  13. Patrick SteinhardtOct 26, 2026
  14. 0/6 log: speed up --follow following renames for non-linear historyMiklos Vajna, Oct 30, 2026
  15. 1/6 t4219: test more --follow cases across mergesMiklos Vajna, Oct 30, 2026
  16. 2/6 log: extract showing the remerge/combined diff of a merge commitMiklos Vajna, Oct 30, 2026
  17. 3/6 log: fix -m --follow losing the history of later parentsMiklos Vajna, Oct 30, 2026
  18. 4/6 log: simplify --follow following renames for non-linear historyMiklos Vajna, Oct 30, 2026
  19. 5/6 log: speed up --follow following renames for non-linear historyMiklos Vajna, Oct 30, 2026
  20. Patrick SteinhardtNov 6, 2026
  21. Miklos VajnaNov 9, 2026
  22. 6/6 log: fix --follow following an edit on a side the merge did not takeMiklos Vajna, Oct 30, 2026
  23. Patrick SteinhardtNov 6, 2026
  24. Miklos VajnaNov 9, 2026
  25. Patrick SteinhardtNov 6, 2026
  26. Miklos VajnaNov 9, 2026
  27. 0/5 log: speed up --follow following renames for non-linear historyMiklos Vajna, Nov 9, 2026
  28. 1/5 t4219: test more --follow cases across mergesMiklos Vajna, Nov 9, 2026
  29. Justin ToblerNov 10, 2026
  30. 2/5 log: extract showing the remerge/combined diff of a merge commitMiklos Vajna, Nov 9, 2026
  31. 3/5 log: fix -m --follow losing the history of later parentsMiklos Vajna, Nov 9, 2026
  32. 4/5 log: simplify --follow following renames for non-linear historyMiklos Vajna, Nov 9, 2026
  33. Toon ClaesNov 10, 2026
  34. 5/5 log: speed up --follow following renames for non-linear historyMiklos Vajna, Nov 9, 2026
  35. Justin ToblerNov 11, 2026
  36. Patrick SteinhardtNov 11, 2026
  37. Miklos VajnaNov 11, 2026
  38. Patrick SteinhardtNov 11, 2026
  39. log: make --follow following renames for non-linear history optionalMiklos Vajna, Nov 12, 2026
  40. Junio C HamanoNov 12, 2026
  41. Patrick SteinhardtNov 13, 2026
  42. log: make --follow following renames for non-linear history optionalMiklos Vajna, Nov 16, 2026
  43. Patrick SteinhardtNov 16, 2026
  44. Junio C HamanoNov 16, 2026
  45. Miklos VajnaNov 17, 2026
  46. Junio C HamanoNov 11, 2026
  47. Junio C HamanoOct 16, 2026
  48. Miklos VajnaOct 14, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.