Re: [PATCH v4 0/6] log: speed up --follow following renames for non-linear history
- From
Miklos Vajna <vmiklos@collabora.com>
- Date
- Nov 9, 2026, 08:01 UTC
- Message-ID
- <avF92deaqNI1G4vw@collabora.com>
- In-Reply-To
- <au3gn7kUFYZWUinE@pks.im>
Hi Patrick,
On Fri, Nov 06, 2026 at 03:14:03PM +0100, Patrick Steinhardt <ps@pks.im> wrote:
Show 5 quoted lines
> please note that the expectation is that you answer to the review > comments directly instead of only answering reviews via the cover letter > of the next version. We want there to be discussions, and reviewers > should not have to figure out by themselves whether you did or did not > address specific concerns.
I see, I'll stick to that way from now on.
> Hmm, okay. But isn't it the case that your speedup patch introduces a > regression where we now don't follow history in some specific cases > anymore, and that regression was only introduced in the preceding > commit? So it's a bit curious to have this be an extra commit.
I've squashed patch 6 into patch 5 in v5. This way 5/5 in v5 is a bit larger, but no patch in the series fixes a regression from the same series.
Show 5 quoted lines
> > Interdiff against v3: > > Instead of an interdiff, could you please send a range-diff next time? > That makes it was easier to see which specific commits I need to have a > look at again, and it also shows diffs to commit messages.
I did it that way in v5.
Thanks,
Miklos