Re: [PATCH v2 1/4] unpack-objects: use size_t for object sizes
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Nov 19, 2026, 10:09 UTC
- Message-ID
- <av7K08K9MIQyxRTW@pks.im>
- In-Reply-To
- <xmqqwlqa6poo.fsf@gitster.g>
On Wed, Nov 18, 2026 at 08:59:35AM -0800, Junio C Hamano wrote:
Show 15 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > > > What's worth documenting is the unexpected parts in your patch, and > > things that may not be immediately obvious to a reviewer. But you also > > document what specifically you are doing to what function, and that's > > quite obvious from the diff itself. So overall I bet that this message > > could be condensed to half or even a third of its size without losing > > much information. > > Good observation and matches my impression on recent proposed log > messages I see on the list, not limited to this author but by > others. Perhaps people should paste their text to their nearby > faviourite LLM and ask it to condense it down by 70% without losing > substance, and notch it down if they feel the result lost too much, > or something.
That assumes that it's their text in the first place, and in many cases I'd say it's obvious that it is not. The offending texts really look too similar for this to be sheer coincidence. So we can probably avoid one roundtrip by telling the LLM to be concise in the first go already.
Patrick