git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/4] unpack-objects: use size_t for object sizes

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 19, 2026, 10:09 UTC
Message-ID
<av7K08K9MIQyxRTW@pks.im>
In-Reply-To
<xmqqwlqa6poo.fsf@gitster.g>
On Wed, Nov 18, 2026 at 08:59:35AM -0800, Junio C Hamano wrote:
Show 15 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > What's worth documenting is the unexpected parts in your patch, and
> > things that may not be immediately obvious to a reviewer. But you also
> > document what specifically you are doing to what function, and that's
> > quite obvious from the diff itself. So overall I bet that this message
> > could be condensed to half or even a third of its size without losing
> > much information.
> 
> Good observation and matches my impression on recent proposed log
> messages I see on the list, not limited to this author but by
> others.  Perhaps people should paste their text to their nearby
> faviourite LLM and ask it to condense it down by 70% without losing
> substance, and notch it down if they feel the result lost too much,
> or something.

That assumes that it's their text in the first place, and in many cases I'd say it's obvious that it is not. The offending texts really look too similar for this to be sheer coincidence. So we can probably avoid one roundtrip by telling the LLM to be concise in the first go already.

Patrick
Previous: Junio C HamanoNext: Elia Pinto
Message 10 of 20 in “use size_t when receiving and verifying packs”
  1. 0/4 use size_t when receiving and verifying packsElia Pinto, Oct 31, 2026
  2. 1/4 unpack-objects: use size_t for object sizesElia Pinto, Oct 31, 2026
  3. 2/4 index-pack: use size_t in write_compressed()Elia Pinto, Oct 31, 2026
  4. 3/4 index-pack: use size_t for object sizesElia Pinto, Oct 31, 2026
  5. 4/4 pack-check: use size_t for the size passed to verify callbacksElia Pinto, Oct 31, 2026
  6. 0/4 use size_t when receiving and verifying packsElia Pinto, Nov 18, 2026
  7. 1/4 unpack-objects: use size_t for object sizesElia Pinto, Nov 18, 2026
  8. Patrick SteinhardtNov 18, 2026
  9. Junio C HamanoNov 18, 2026
  10. Patrick SteinhardtNov 19, 2026
  11. Elia PintoNov 19, 2026
  12. Patrick SteinhardtNov 19, 2026
  13. Elia PintoNov 19, 2026
  14. 2/4 index-pack: use size_t in write_compressed()Elia Pinto, Nov 18, 2026
  15. Patrick SteinhardtNov 18, 2026
  16. Elia PintoNov 19, 2026
  17. 3/4 index-pack: use size_t for object sizesElia Pinto, Nov 18, 2026
  18. 4/4 pack-check: use size_t for the size passed to verify callbacksElia Pinto, Nov 18, 2026
  19. Patrick SteinhardtNov 18, 2026
  20. Elia PintoNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.