git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/4] index-pack: use size_t in write_compressed()

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Nov 19, 2026, 06:05 UTC
Message-ID
<20261119060524.775205-2-gitter.spiros@gmail.com>
In-Reply-To
<av2pOWbYxNDYvS9p@pks.im>
On Wed, Nov 18, 2026 at 02:33:45PM +0100, Patrick Steinhardt wrote:
Show 7 quoted lines
> Hmm. It's probably an improvement, but the only caller does this:
>
> 	obj[1].idx.offset += write_compressed(f, buf, size);
>
> That's a `struct pack_idx_entry`, but its `offset` field is of type
> `off_t`, which is signed. It feels sufficiently unlikely to ever
> overflow, but should we verify regardless that we don't?

It costs little, and index-pack already does so for the data it reads: use() dies with "pack too large for current definition of off_t" when signed_add_overflows(consumed_bytes, bytes). I will do the same in append_obj_to_pack() in v3.

> Not even an EXPENSIVE one?

I can add one. It needs a local base of 4GiB and a thin pack with a delta against it. Writing that small delta by hand keeps pack-objects out of the picture, so only index-pack has to hold the base in memory. As it still takes a lot of memory and time, I would guard it with its own variable, like t5608 does with GIT_TEST_CLONE_2GB.

Thanks, Elia

Previous: Patrick SteinhardtNext: Elia Pinto
Message 16 of 20 in “use size_t when receiving and verifying packs”
  1. 0/4 use size_t when receiving and verifying packsElia Pinto, Oct 31, 2026
  2. 1/4 unpack-objects: use size_t for object sizesElia Pinto, Oct 31, 2026
  3. 2/4 index-pack: use size_t in write_compressed()Elia Pinto, Oct 31, 2026
  4. 3/4 index-pack: use size_t for object sizesElia Pinto, Oct 31, 2026
  5. 4/4 pack-check: use size_t for the size passed to verify callbacksElia Pinto, Oct 31, 2026
  6. 0/4 use size_t when receiving and verifying packsElia Pinto, Nov 18, 2026
  7. 1/4 unpack-objects: use size_t for object sizesElia Pinto, Nov 18, 2026
  8. Patrick SteinhardtNov 18, 2026
  9. Junio C HamanoNov 18, 2026
  10. Patrick SteinhardtNov 19, 2026
  11. Elia PintoNov 19, 2026
  12. Patrick SteinhardtNov 19, 2026
  13. Elia PintoNov 19, 2026
  14. 2/4 index-pack: use size_t in write_compressed()Elia Pinto, Nov 18, 2026
  15. Patrick SteinhardtNov 18, 2026
  16. Elia PintoNov 19, 2026
  17. 3/4 index-pack: use size_t for object sizesElia Pinto, Nov 18, 2026
  18. 4/4 pack-check: use size_t for the size passed to verify callbacksElia Pinto, Nov 18, 2026
  19. Patrick SteinhardtNov 18, 2026
  20. Elia PintoNov 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.