git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] unit-tests: ignore --long-tests

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 23, 2026, 06:50 UTC
Message-ID
<atsDvfHx3_EkrI6Z@pks.im>
In-Reply-To
<20261022-ks-unit-tests-ignore-long-tests-v1-2-554a590d418b@gmail.com>
On Thu, Oct 22, 2026 at 04:31:58PM +0530, Kaartic Sivaraam wrote:
Show 8 quoted lines
> In the same spirit as 9faf3963b6 (t: introduce compatibility options to
> clar-based tests, 2024-12-13), we should ignore -l / --long-tests passed
> to our clar tests. It may be passed along while manually running tests
> via a command as follows:
> 
>   $ meson test -v --test-args='-ilx'
> 
> So, ignore -l / --long-tests in our clar tests.

TIL, I didn't even know we had this switch to run long tests. That makes me wonder whether we should have an "--features-testbed" switch to make it easy to run tests same as our CI job that sets all those test variables, and then adapt CI to use it. It's always a pain to specify all of these environment variables.

That's of course outside of the scope of this patch series, but I've got a pending series where I may be able to squeeze this into.

> This does not show up as a problem while running our CI as we enable
> the expensive prerequiiste via the GIT_TEST_LONG env variable.
s/prerequiiste/prerequisite/
Show 12 quoted lines
> diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
> index d066c8a4c8..06ffd0f5bb 100644
> --- a/t/unit-tests/unit-test.c
> +++ b/t/unit-tests/unit-test.c
> @@ -28,6 +28,7 @@ int cmd_main(int argc, const char **argv)
>  		 */
>  		OPT_NOOP_NOARG('d', "debug"),
>  		OPT_NOOP_NOARG(0, "github-workflow-markup"),
> +		OPT_NOOP_NOARG('l', "long-tests"),
>  		OPT_NOOP_NOARG(0, "no-bin-wrappers"),
>  		OPT_NOOP_ARG(0, "no-chain-lint"),
>  		OPT_NOOP_ARG(0, "root"),
Looks obviously good to me, thanks!
Patrick
Previous: Kaartic SivaraamNext: Kaartic Sivaraam
Message 5 of 12 in “Make our clar tests ignore the long-tests argument”
  1. 0/2 Make our clar tests ignore the long-tests argumentKaartic Sivaraam, Oct 22, 2026
  2. 1/2 unit-tests: reshuffle NOOP arguments to maintain orderKaartic Sivaraam, Oct 22, 2026
  3. Patrick SteinhardtOct 23, 2026
  4. 2/2 unit-tests: ignore --long-testsKaartic Sivaraam, Oct 22, 2026
  5. Patrick SteinhardtOct 23, 2026
  6. Kaartic SivaraamOct 23, 2026
  7. 0/2 Make our clar tests ignore the long-tests argumentKaartic Sivaraam, Oct 26, 2026
  8. 1/2 unit-tests: reshuffle NOOP arguments to maintain orderKaartic Sivaraam, Oct 26, 2026
  9. 2/2 unit-tests: ignore --long-testsKaartic Sivaraam, Oct 26, 2026
  10. Patrick SteinhardtOct 26, 2026
  11. Junio C HamanoOct 26, 2026
  12. Jeff KingOct 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.