Re: [PATCH v2 0/2] Make our clar tests ignore the long-tests argument
- From
Jeff King <peff@peff.net>
- Date
- Oct 27, 2026, 17:44 UTC
- Message-ID
- <20261027174442.GA97882@coredump.intra.peff.net>
- In-Reply-To
- <20261026-ks-unit-tests-ignore-long-tests-v2-0-fdbbefbd19fb@gmail.com>
On Mon, Oct 26, 2026 at 01:01:03PM +0530, Kaartic Sivaraam wrote:
Show 5 quoted lines
> On searching for how these were handled before, I stumbled across > 9faf3963b6 (t: introduce compatibility options to clar-based tests, > 2024-12-13) which handled this by adding such arguments as NOOP > arguments to t/unit-tests/unit-test.c. So, this patch does the same > to make unit-test ignore the '-l' passed to it.
Your patch looks obviously good, but it prompted me to polish and send in a much larger fix that I think makes this fallback option parsing obsolete:
https://lore.kernel.org/git/20261027173205.GA97799@coredump.intra.peff.net/
I don't propose to replace your series here with mine, but just that you might be interested in it. ;)
-Peff