git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] Make our clar tests ignore the long-tests argument

From
Jeff King <peff@peff.net>
Date
Oct 27, 2026, 17:44 UTC
Message-ID
<20261027174442.GA97882@coredump.intra.peff.net>
In-Reply-To
<20261026-ks-unit-tests-ignore-long-tests-v2-0-fdbbefbd19fb@gmail.com>
On Mon, Oct 26, 2026 at 01:01:03PM +0530, Kaartic Sivaraam wrote:
Show 5 quoted lines
> On searching for how these were handled before, I stumbled across
> 9faf3963b6 (t: introduce compatibility options to clar-based tests,
> 2024-12-13) which handled this by adding such arguments as NOOP
> arguments to t/unit-tests/unit-test.c. So, this patch does the same
> to make unit-test ignore the '-l' passed to it.

Your patch looks obviously good, but it prompted me to polish and send in a much larger fix that I think makes this fallback option parsing obsolete:

  https://lore.kernel.org/git/20261027173205.GA97799@coredump.intra.peff.net/

I don't propose to replace your series here with mine, but just that you might be interested in it. ;)

-Peff
Previous: Junio C Hamano
Message 12 of 12 in “Make our clar tests ignore the long-tests argument”
  1. 0/2 Make our clar tests ignore the long-tests argumentKaartic Sivaraam, Oct 22, 2026
  2. 1/2 unit-tests: reshuffle NOOP arguments to maintain orderKaartic Sivaraam, Oct 22, 2026
  3. Patrick SteinhardtOct 23, 2026
  4. 2/2 unit-tests: ignore --long-testsKaartic Sivaraam, Oct 22, 2026
  5. Patrick SteinhardtOct 23, 2026
  6. Kaartic SivaraamOct 23, 2026
  7. 0/2 Make our clar tests ignore the long-tests argumentKaartic Sivaraam, Oct 26, 2026
  8. 1/2 unit-tests: reshuffle NOOP arguments to maintain orderKaartic Sivaraam, Oct 26, 2026
  9. 2/2 unit-tests: ignore --long-testsKaartic Sivaraam, Oct 26, 2026
  10. Patrick SteinhardtOct 26, 2026
  11. Junio C HamanoOct 26, 2026
  12. Jeff KingOct 27, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.