Re: [PATCH 1/2] packfile: move around `close_pack()`

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 2, 2026, 19:38 UTC
Message-ID: <asAIH5JOfGMpJqEN@pks.im>
In-Reply-To: <DLUL2YDALTAV.15LO4AB7BDMLR@fastmail.com>

On Fri, Oct 02, 2026 at 03:02:30PM -0400, Mark C. Chu-Carroll wrote:

Show 7 quoted lines

> On Fri Oct 2, 2026 at 3:34 AM EDT, Patrick Steinhardt wrote:
> > In the next commit we'll want to access the delta base cache in
> > `close_pack()`. Move the function after the declaration of the cache to
> > prepare for this.
> 
> Maybe I'm just being clueless, but how does moving an unmodified function
> help with the subsequent change?

This is mostly done to avoid a forward declaration of the function that would otherwise be necessary.

Patrick