Re: [PATCH] completion: complete 'git worktree repair'

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 14, 2026, 06:29 UTC
Message-ID: <aqeUWrx7pbzDVbVt@pks.im>
In-Reply-To: <pull.2218.git.1789171955370.gitgitgadget@gmail.com>

On Sat, Sep 12, 2026 at 12:12:35AM +0000, Yoichi NAKAYAMA via GitGitGadget wrote:

Show 5 quoted lines

> From: Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>
> 
> Added completion support for the 'repair' subcommand of worktree. It
> optionally receives a list of paths to linked worktrees or paths to
> worktrees with broken links.

We typically write commit messages in imperative mood, as if instructing the code to change. We also briefly describe the status quo, even though it's not as important in this particular case. An example could be:

  Our Bash completion does not know to complete the "repair" subcommand
  for git-worktree(1). Add support for it.

One could also try to add in your bit about worktree paths, but that's something that's quite obviously visible from the diff anyway. So this may or may not be valuable.

Other than that the patch looks good to me.

Thanks!

Patrick