Re: [PATCH] completion: complete 'git worktree repair'

From: Yoichi Nakayama <yoichi.nakayama@gmail.com>
Date: Sep 14, 2026, 12:08 UTC
Message-ID: <CAF5D8-v2FSJX_dHFmNzaudAtPu76pVX0n5GhMnGjjnT2f3g3Ng@mail.gmail.com>
In-Reply-To: <aqeUWrx7pbzDVbVt@pks.im>

On Mon, Sep 14, 2026 at 3:29 PM Patrick Steinhardt <ps@pks.im> wrote:

Show 18 quoted lines

>
> On Sat, Sep 12, 2026 at 12:12:35AM +0000, Yoichi NAKAYAMA via GitGitGadget wrote:
> > From: Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>
> >
> > Added completion support for the 'repair' subcommand of worktree. It
> > optionally receives a list of paths to linked worktrees or paths to
> > worktrees with broken links.
>
> We typically write commit messages in imperative mood, as if instructing
> the code to change. We also briefly describe the status quo, even though
> it's not as important in this particular case. An example could be:
>
>   Our Bash completion does not know to complete the "repair" subcommand
>   for git-worktree(1). Add support for it.
>
> One could also try to add in your bit about worktree paths, but that's
> something that's quite obviously visible from the diff anyway. So this
> may or may not be valuable.

Thank you for your comment. Since this is not limited to bash, it also adds completion support for zsh and tcsh via git-completion.{zsh,tcsh}. So I'd like to modify the body of the commit message as follows:

  The completion scripts do not complete the "repair" subcommand for
  git-worktree(1). Add support for it.

Thanks

Show 5 quoted lines

> Other than that the patch looks good to me.
>
> Thanks!
>
> Patrick

-- 
Yoichi NAKAYAMA