Re: [PATCH] versioncmp: fix typo in versioncmp.c, t/t0022-crlf-rename.sh

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 31, 2026, 06:59 UTC
Message-ID: <apUmRknf8gnd-Izp@pks.im>
In-Reply-To: <20260828-typo-fix-v1-1-24e80a87ed53@gmail.com>

On Fri, Aug 28, 2026 at 02:38:01PM +0530, Hardik Kumar wrote:

> The patch fixes two typos in two places.
> versoncmp.c:            "fractionnal" -> "fractional"

s/versoncmp/versioncmp/

> t/t0022-crlf-rename.sh: "similiarity" -> "similarity"

The patch subject only mentions "versioncmp", so it's quite surprising to see a change to t0022, as well. Maybe you should just split it up into two patches, even though that feels somewhat heavyweight.

> NFC only updating a comment and a test_description

I have no idea what this means.

Show 25 quoted lines

> diff --git a/t/t0022-crlf-rename.sh b/t/t0022-crlf-rename.sh
> index 9bd863a970..328c6e5903 100755
> --- a/t/t0022-crlf-rename.sh
> +++ b/t/t0022-crlf-rename.sh
> @@ -1,6 +1,6 @@
>  #!/bin/sh
>  
> -test_description='ignore CR in CRLF sequence while computing similiarity'
> +test_description='ignore CR in CRLF sequence while computing similarity'
>  
>  . ./test-lib.sh
>  
> diff --git a/versioncmp.c b/versioncmp.c
> index 3a81b17bc1..f1e451755a 100644
> --- a/versioncmp.c
> +++ b/versioncmp.c
> @@ -15,7 +15,7 @@
>  
>  /*
>   * states: S_N: normal, S_I: comparing integral part, S_F: comparing
> - * fractionnal parts, S_Z: idem but with leading Zeroes only
> + * fractional parts, S_Z: idem but with leading Zeroes only
>   */
>  #define  S_N    0x0
>  #define  S_I    0x3

The typo-fixes look obviously good.

Thanks!

Patrick