Re: [PATCH 09/11] setup: rename ref storage format environment variables
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 7, 2026, 10:00 UTC
- Message-ID
- <ap6LUs6-5h0oui3l@pks.im>
- In-Reply-To
- <CAOLa=ZT7WQ-J-i6n_nqm0MtDypm3V=3jyG6y6a8U=EvicMqgow@mail.gmail.com>
On Fri, Sep 04, 2026 at 09:20:30AM -0400, Karthik Nayak wrote:
Show 14 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > > diff --git a/environment.h b/environment.h > > index e7ec5b0437..e6b933f8db 100644 > > --- a/environment.h > > +++ b/environment.h > > @@ -44,6 +44,7 @@ > > #define GIT_TEXT_DOMAIN_DIR_ENVIRONMENT "GIT_TEXTDOMAINDIR" > > #define GIT_ATTR_SOURCE_ENVIRONMENT "GIT_ATTR_SOURCE" > > #define GIT_REFERENCE_BACKEND_ENVIRONMENT "GIT_REFERENCE_BACKEND" > > +#define GIT_REF_STORAGE_ENVIRONMENT "GIT_REF_STORAGE" > > Shouldn't we also be adding and using > GIT_DEFAULT_REF_STORAGE_ENVIRONMENT? The rest of the changes look to be > in order.
I refrained from doing so because the other variable wasn't listed here, either, so I was mostly aiming for compatibility with the previous code. Happy to change though if you feel strongly about it.
Patrick