git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/11] builtin/init: rename "--ref-format=" to "--ref-storage="

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 7, 2026, 10:00 UTC
Message-ID
<ap6LTHNgPGAVyZDu@pks.im>
In-Reply-To
<CAOLa=ZQO05kg6ekVJf-0Hkmq8rMVQuGox6O7DJL6mMTRA7_HLw@mail.gmail.com>
On Fri, Sep 04, 2026 at 09:05:20AM -0400, Karthik Nayak wrote:
Show 15 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/Documentation/config/init.adoc b/Documentation/config/init.adoc
> > index 7b4abdaf8b..9c78440192 100644
> > --- a/Documentation/config/init.adoc
> > +++ b/Documentation/config/init.adoc
> > @@ -109,8 +109,10 @@ int cmd_init_db(int argc,
> >  			   N_("override the name of the initial branch")),
> >  		OPT_STRING(0, "object-format", &object_format, N_("hash"),
> >  			   N_("specify the hash algorithm to use")),
> > -		OPT_STRING(0, "ref-format", &ref_format, N_("format"),
> > -			   N_("specify the reference format to use")),
> > +		OPT_STRING(0, "ref-storage", &ref_storage, N_("format"),
> > +			   N_("specify the reference storage format to use")),
> 
> shouldn't we use 'ref-storage' for the argh value too?

I think having "format" as parameter name makes more sense. In any case, going by Junio's suggestion I've now renamed everything to ref storage format, and that makes "format" an even better parameter name, I think.

Show 14 quoted lines
> > @@ -173,10 +175,10 @@ int cmd_init_db(int argc,
> >  			die(_("unknown hash algorithm '%s'"), object_format);
> >  	}
> >
> > -	if (ref_format) {
> > -		ref_storage_format = ref_storage_format_by_name(ref_format);
> > +	if (ref_storage) {
> > +		ref_storage_format = ref_storage_format_by_name(ref_storage);
> >  		if (ref_storage_format == REF_STORAGE_FORMAT_UNKNOWN)
> > -			die(_("unknown ref storage format '%s'"), ref_format);
> > +			die(_("unknown ref storage format '%s'"), ref_storage);
> 
> Funny that we error'd out with 'ref storage' while the name was
> ref_format.
Well, it's inconsistencies all over the place :)
Patrick
Previous: Karthik NayakNext: Patrick Steinhardt
Message 4 of 20 in “Fix inconsistent ref storage format terminology”
  1. 00/11 Fix inconsistent ref storage format terminologyPatrick Steinhardt, Sep 4, 2026
  2. 01/11 builtin/init: rename "--ref-format=" to "--ref-storage="Patrick Steinhardt, Sep 4, 2026
  3. Karthik NayakSep 4, 2026
  4. Patrick SteinhardtSep 7, 2026
  5. 02/11 builtin/clone: rename "--ref-format=" to "--ref-storage="Patrick Steinhardt, Sep 4, 2026
  6. 03/11 builtin/refs: rename "--ref-format=" to "--ref-storage="Patrick Steinhardt, Sep 4, 2026
  7. 04/11 builtin/submodule: rename "--ref-format=" to "--ref-storage="Patrick Steinhardt, Sep 4, 2026
  8. 05/11 builtin/rev-parse: rename "--show-ref-format" to "--show-ref-storage"Patrick Steinhardt, Sep 4, 2026
  9. 06/11 help: rename "default-ref-format" to "default-ref-storage"Patrick Steinhardt, Sep 4, 2026
  10. 07/11 refs: expose function to parse reference URIsPatrick Steinhardt, Sep 4, 2026
  11. Karthik NayakSep 4, 2026
  12. 08/11 setup: refactor how we configure the ref storage formatPatrick Steinhardt, Sep 4, 2026
  13. 09/11 setup: rename ref storage format environment variablesPatrick Steinhardt, Sep 4, 2026
  14. Karthik NayakSep 4, 2026
  15. Patrick SteinhardtSep 7, 2026
  16. 10/11 setup: rename "init.defaultRefFormat" to "init.defaultRefStorage"Patrick Steinhardt, Sep 4, 2026
  17. 11/11 setup: allow "git init --ref-storage=" to specify a payloadPatrick Steinhardt, Sep 4, 2026
  18. Karthik NayakSep 4, 2026
  19. Junio C HamanoSep 4, 2026
  20. Patrick SteinhardtSep 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.