Re: [PATCH 2/2] ci: bump ubuntu image version for static-analysis job

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 11, 2026, 05:02 UTC
Message-ID: <anqs8mT78znJmUwJ@pks.im>
In-Reply-To: <xmqq7blx7tii.fsf@gitster.g>

On Mon, Aug 10, 2026 at 10:52:21AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Taking a step back, I do have to wonder whether the Cocci files have
> > been adding any kind of value in the first place. I myself introduced
> > some of them in contexts where I made sweeping changes to our APIs, so
> > that any in-flight topics can be trivially adjusted via Coccinelle. But
> > I very much doubt that anyone ever used those to adapt their in-flight
> > patch series at all.
> >
> > So maybe we should just not do that anymore?
> 
> We still do catch when somebody writes "if (a == NULL)", no?

Yes! What I was trying to say is that we maybe shouldn't add Cocci files for temporary migrations anymore, but still keep (and extend) them for evertyhing where we want to consistently catch antipatterns going forward.

Overall I have a feeling that I'm overthinking this though :) Maybe it ultimately doesn't matter too much and we just continue what we're doing and then clean up every once in a while when too much cruft has accumulated.

Patrick