Re: [PATCH 2/2] ci: bump ubuntu image version for static-analysis job

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 7, 2026, 10:24 UTC
Message-ID: <anWyV9Q4Cmsa5AoT@pks.im>
In-Reply-To: <20260726083905.GB3529069@coredump.intra.peff.net>

On Sun, Jul 26, 2026 at 04:39:05AM -0400, Jeff King wrote:

Show 7 quoted lines

> We recently ran into a case[1] where old versions of coccinelle ran very
> slowly, but newer ones are fine. The version we use in GitHub's CI was
> the old slow version, leading to timeouts of the static-analysis job.
> 
> We get the old version because we ask for the ubuntu-22.04 image. That
> has coccinelle 1.1.1, but the "fast" improvement is in coccinelle 1.3.0,
> specifically their 58619b8fe (break up envs for e1 & e2, 2024-08-18).

I have been wondering about slow Coccinelle for a while now. Making things faster via a simple version upgrade is great, as it comes almost for free.

But that being said, we also have a bunch of Coccinelle rules nowadays, and my gut feeling tells me that there's a bunch of them that aren't useful anymore. "refs", "object_id", "the_repository", "git_config_number", "index-compatibility" and "context_fn_ctx" all look like files that we could probably just get rid of because we have long done the migrations, and it's unlikely anybody still has patches that use the pre-migration variants.

They'd of course require a bit of a deeper look, but that could be another way to speed up Coccinelle for us. Even though I cannot say for sure by how much, I didn't give it a test.

Thanks!

Patrick