Re: [PATCH 2/2] http.c: add http.sslCertType and http.sslKeyType

From: Karsten Weiss <knweiss@gmx.de>
Date: Jun 15, 2009, 17:43 UTC
Message-ID: <alpine.OSX.2.00.0906151927010.816@xor.localnet>
In-Reply-To: <1245033541-15558-2-git-send-email-lodatom@gmail.com>

Hi Mark!

On Sun, 14 Jun 2009, Mark Lodato wrote:

> Add two new configuration variables, http.sslCertType and
> http.sslKeyType, which tell libcurl the filetype for the SSL client
> certificate and private key, respectively.  The main benefit is to allow
> PKCS12 certificates for users with libcurl >= 7.13.0.

This is interesting. Thanks for working on that!

(However, it's a similar issue like the question whether the private key is encrypted or not: Usability would be better if the certificate type could be determined automatically (without having to violate the layering)).

>> +http.sslKeyType::
> +	Filetype for SSL private key.  Must be "PEM" (default), "DER", or
> +	(if libcurl >= 7.13.0) "P12".  Can be overridden by the
> +	'GIT_SSL_CERT_TYPE' environment variable.

                  ^^^^
                  KEY

Regards, Karsten