git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] http.c: add http.sslCertType and http.sslKeyType

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 16, 2009, 05:56 UTC
Message-ID
<7vprd4g1rv.fsf@alter.siamese.dyndns.org>
In-Reply-To
<ca433830906151755t783fbf98k3fd09e4bdd6781e8@mail.gmail.com>
Mark Lodato <lodatom@gmail.com> writes:
Show 9 quoted lines
> This brings up a good point: Should we (I) try to implement (client
> certificate) usability features in git to work around deficiencies in
> libcurl, or should we (I) write patches to fix/enhance libcurl
> directly?  The latter would be much easier (though I could be wrong)
> and would benefit other programs using libcurl, but would require
> users to upgrade libcurl to get these new features, and of course
> would rely on the libcurl developers accepting the patches.  I am
> willing to do either, but I think the libcurl route would be better.
> Any thoughts?

I agree that would be a better approach in the longer term. There is no point in many projects that use libcURL reinventing the wheel that could be in the shared library.

Perhaps we could do both ;-).

That is, (1) give libcURL a way to allow callers ask if the key/cert is encrypted, and then (2) on git side we only add code to ask libcURL using that interface _only if and when available_; otherwise we do not even try to bypass layers but just ask the user to tell us via configuration (or command line).

Previous: Mark LodatoNext: Junio C Hamano
Message 5 of 11 in “http.c: fix compiling with libcurl 7.9.2”
  1. 1/2 http.c: fix compiling with libcurl 7.9.2Mark Lodato, Jun 15, 2009
  2. 2/2 http.c: add http.sslCertType and http.sslKeyTypeMark Lodato, Jun 15, 2009
  3. Karsten WeissJun 15, 2009
  4. Mark LodatoJun 16, 2009
  5. Junio C HamanoJun 16, 2009
  6. Junio C HamanoJun 16, 2009
  7. Karsten WeissJun 16, 2009
  8. Mark LodatoJun 16, 2009
  9. Junio C HamanoJun 15, 2009
  10. Tay Ray ChuanJun 15, 2009
  11. Mike RalphsonJun 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.