Re: [PATCH] fix potential infinite loop given large unsigned integer

From

Tony Finch <dot@dotat.at>

Date

Aug 10, 2009, 18:19 UTC

Message-ID

<alpine.LSU.2.00.0908101914470.14039@hermes-2.csi.cam.ac.uk>

In-Reply-To

<7v3a81a13z.fsf@alter.siamese.dyndns.org>

On Sun, 9 Aug 2009, Junio C Hamano wrote:

> +	if (numbered) {
> +		static char num_buf[64];
>  		rev.total = total + start_number - 1;
> +		sprintf(num_buf, "%d", rev.total);
> +		rev.num_width = strlen(num_buf);
> +	}

why not

	if (numbered) {
		rev.total = total + start_number - 1;
		rev.num_width = snprintf(NULL, 0, "%d", rev.total);
	}

?

Tony.

-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
GERMAN BIGHT HUMBER: SOUTHWEST 5 TO 7. MODERATE OR ROUGH. SQUALLY SHOWERS.
MODERATE OR GOOD.