Re: [PATCH] fix potential infinite loop given large unsigned integer

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 10, 2009, 12:24 UTC
Message-ID: <alpine.DEB.1.00.0908101421340.8324@intel-tinevez-2-302>
In-Reply-To: <40aa078e0908100412l3c2afd1bnda9b10aaf1de383f@mail.gmail.com>

Hi,

On Mon, 10 Aug 2009, Erik Faye-Lund wrote:

Show 9 quoted lines

> On Mon, Aug 10, 2009 at 7:24 AM, Christian
> Couder<chriscool@tuxfamily.org> wrote:
> >> log10() appears to be C99, but can be emulated on earlier C-versions by
> >> doing #define log10(x) (log(x) / log(10.0))
> >
> > That would mean linking with -lm?
> 
> I guess so. Are we currently trying to avoid linking to the math-parts 
> of libc?

Yes.

I guess we could fix the overflow thing very easily, though:

static unsigned int digits_of_number(unsigned int number) {
	unsigned int result;
	for (result = 1; number; number /= 10, result++)
		; /* do nothing */
	return result;
}

Ciao, Dscho