[PATCH] commit: resurrect "gc --auto" at the end
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 2, 2008, 13:40 UTC
- Message-ID
- <alpine.LSU.1.00.0804021538220.4008@racer.site>
- In-Reply-To
- <7vr6drsl47.fsf@gitster.siamese.dyndns.org>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
As the scripted version of git-commit did, we now call gc --auto just before the post-commit hook.
Any errors of gc --auto should be non-fatal, so we do not catch those; the user should see them anyway.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> ---
Junio wrote: > > * "git commit" used to have one [call to 'gc --auto'] at the > end in the scripted version, but seems to have lost it in C > rewrite.
How about this?
builtin-commit.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c index 660a345..bec62b2 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -863,6 +863,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix) char *nl, *p; unsigned char commit_sha1[20]; struct ref_lock *ref_lock; + const char *argv_gc_auto[] = { "gc", "--auto", NULL }; git_config(git_commit_config); @@ -987,6 +988,8 @@ int cmd_commit(int argc, const char **argv, const char *prefix) "not exceeded, and then \"git reset HEAD\" to recover."); rerere(); + /* We ignore errors in 'gc --auto', since the user should see them. */ + run_command_v_opt(argv_gc_auto, RUN_GIT_CMD); run_hook(get_index_file(), "post-commit", NULL); if (!quiet) print_summary(prefix, commit_sha1);
-- 1.5.5.rc2.30.gf2056