git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git gc --auto: defer on battery

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Mar 30, 2008, 23:53 UTC
Message-ID
<20080330235322.GV11666@genesis>
In-Reply-To
<alpine.LSU.1.00.0803310137090.18259@racer.site>
On Mon, Mar 31, 2008 at 01:41:18AM +0200, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> And what about system dependency?  I mean, if at all, this stuff belongs 
> to compat/.  Definitely not into builtin-gc.c.  And yes, that means that 
> you should not call the function is_on_battery() blindly, but _only_ if 
> defer_on_battery is set.

Hm, should I just move it to there or should there be some kind of check? Currently it just tries to open that file under /sys and if fails, it just assumes we are not on battery. I think that's the expected behaviour on systems not having a /sys filesystem.

As far as I see, compat/ is for functions which are available on some systems but not an all ones. Obviously is_on_battery() won't be available on any system. :)

The other issues (I hope) are fixed in the second patch.
Previous: Johannes SchindelinNext: Brandon Casey
Message 24 of 27 in “git gc --auto: defer on battery”
  1. git gc --auto: defer on batteryMiklos Vajna, Mar 30, 2008
  2. Björn SteinbrinkMar 30, 2008
  3. git gc --auto: defer on batteryMiklos Vajna, Mar 30, 2008
  4. Björn SteinbrinkMar 30, 2008
  5. Linus TorvaldsMar 30, 2008
  6. Björn SteinbrinkMar 31, 2008
  7. Junio C HamanoMar 31, 2008
  8. Linus TorvaldsMar 31, 2008
  9. Björn SteinbrinkMar 31, 2008
  10. fetchmail (Re: [PATCH] git gc --auto: defer on battery)Linus Torvalds, Mar 31, 2008
  11. commit: resurrect "gc --auto" at the endJohannes Schindelin, Apr 2, 2008
  12. Johannes SchindelinMay 14, 2008
  13. Junio C HamanoMay 14, 2008
  14. Johannes SchindelinMay 14, 2008
  15. Holger SchurigMay 15, 2008
  16. 0/4 add pre-auto-gc hook for git-gc --autoMiklos Vajna, Mar 31, 2008
  17. 1/4 git-gc --auto: add pre-auto-gc hookMiklos Vajna, Mar 31, 2008
  18. 2/4 git-gc: add a --no-verify option to bypass the pre-auto-gc hookMiklos Vajna, Mar 31, 2008
  19. 3/4 Documentation/hooks: add pre-auto-gc hookMiklos Vajna, Mar 31, 2008
  20. 4/4 templates: add an example pre-auto-gc hookMiklos Vajna, Mar 31, 2008
  21. Brian GernhardtMar 31, 2008
  22. Joey HessMar 31, 2008
  23. Johannes SchindelinMar 30, 2008
  24. Miklos VajnaMar 30, 2008
  25. Brandon CaseyMar 31, 2008
  26. Miklos VajnaMar 31, 2008
  27. Brandon CaseyMar 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.