git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 10, 2008, 18:20 UTC
Message-ID
<alpine.LSU.1.00.0803101919060.3975@racer.site>
In-Reply-To
<Pine.LNX.4.64.0802151346000.18292@ds9.cixit.se>
Hi,
On Fri, 15 Feb 2008, Peter Karlsson wrote:
Show 9 quoted lines
> Johannes Schindelin:
> 
> > Can you please test?  The we could at least add a "Tested-by:" to the 
> > commit message.
> 
> When starting from the "Git bash" shell, it works.
> 
> When starting from a Cygwin prompt, it does not work ($MSYSTEM is not 
> set).

Can you please test this patch (both from interactive and ssh'ed sessions)?

-- snipsnap -- [PATCH] bisect view: call gitk if Cygwin's SESSIONNAME variable is set

It seems that Cygwin sets the variable SESSIONNAME when an interactive session is running, and does not set it when you log in via ssh.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-bisect.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 2c32d0b..af8f9e3 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -333,7 +333,7 @@ bisect_visualize() {
 
 	if test $# = 0
 	then
-		case "${DISPLAY+set}${MSYSTEM+set}${SECURITYSESSIONID+set}" in
+		case "${DISPLAY+set}${SESSIONNAME+set}${MSYSTEM+set}${SECURITYSESSIONID+set}" in
 		'')	set git log ;;
 		set*)	set gitk ;;
 		esac
-- 
1.5.4.4.643.g7cb9b.dirty
Previous: Johannes SchindelinNext: Peter Karlsson
Message 6 of 7 in “bisect view: check for MinGW32 and MacOSX in addition to X11”
  1. bisect view: check for MinGW32 and MacOSX in addition to X11Johannes Schindelin, Feb 14, 2008
  2. Peter KarlssonFeb 15, 2008
  3. Johannes SchindelinFeb 15, 2008
  4. Peter KarlssonFeb 15, 2008
  5. Johannes SchindelinFeb 15, 2008
  6. Johannes SchindelinMar 10, 2008
  7. Peter KarlssonMar 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.