git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 14, 2008, 12:29 UTC
Message-ID
<alpine.LSU.1.00.0802141228300.30505@racer.site>

When deciding if gitk or git-log should be used to visualize the current state, the environment variable DISPLAY was checked. Now, we check MSYSTEM (for MinGW32/MSys) and SECURITYSESSIONID (for MacOSX) in addition.

Note that there is currently no way to ssh into MinGW32, and that SECURITYSESSIONID is not set automatically on MacOSX when ssh'ing into it. So this patch should be safe.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	Technically, we do not even support MinGW32 yet in git.git,
	but does it really hurt?  After all, you can call cygwin's git
	from MinGW32 as well...
 git-bisect.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-bisect.sh b/git-bisect.sh
index 6594a62..74715ed 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -331,9 +331,9 @@ bisect_visualize() {
 
 	if test $# = 0
 	then
-		case "${DISPLAY+set}" in
+		case "${DISPLAY+set}${MSYSTEM+set}${SECURITYSESSIONID+set}" in
 		'')	set git log ;;
-		set)	set gitk ;;
+		set*)	set gitk ;;
 		esac
 	else
 		case "$1" in
-- 
1.5.4.1.1353.g0d5dd
Next: Peter Karlsson
Message 1 of 7 in “bisect view: check for MinGW32 and MacOSX in addition to X11”
  1. bisect view: check for MinGW32 and MacOSX in addition to X11Johannes Schindelin, Feb 14, 2008
  2. Peter KarlssonFeb 15, 2008
  3. Johannes SchindelinFeb 15, 2008
  4. Peter KarlssonFeb 15, 2008
  5. Johannes SchindelinFeb 15, 2008
  6. Johannes SchindelinMar 10, 2008
  7. Peter KarlssonMar 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.