git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-clone: fix for new unpack_trees() semantics

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 10, 2008, 10:58 UTC
Message-ID
<alpine.LSU.1.00.0803101157300.3975@racer.site>
In-Reply-To
<alpine.LNX.1.00.0803091911010.19665@iabervon.org>
Hi,
On Sun, 9 Mar 2008, Daniel Barkalow wrote:
Show 8 quoted lines
> On Mon, 10 Mar 2008, Johannes Schindelin wrote:
> 
> > Yes.  And this sets dst_index (what I tried to hint at with my patch).
> 
> Oh, yes. Your patch is what prompted me to fix that part (and to find 
> that Linus's unpack_trees was in next now). But seeing src_index in your 
> patch made me wonder what it wanted a source index for anyway, since 
> this is the first index we've had in this repo.

Well, stupid copy-'n-paste. Well, not all that stupid: because of the twoway_merge (and because the segmentation fault was in a line accessing src_index), I assumed that the src_index is needed.

But your explanation that oneway_merge is all we want makes tons of sense.

Ciao, Dscho

Previous: Daniel Barkalow
Message 8 of 8 in “Build in clone”
  1. 10/11 Build in cloneDaniel Barkalow, Mar 8, 2008
  2. builtin-clone: fix for new unpack_trees() semanticsJohannes Schindelin, Mar 9, 2008
  3. Daniel BarkalowMar 9, 2008
  4. Johannes SchindelinMar 9, 2008
  5. Daniel BarkalowMar 9, 2008
  6. Johannes SchindelinMar 9, 2008
  7. Daniel BarkalowMar 9, 2008
  8. Johannes SchindelinMar 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.