From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 10 Mar 2008 10:58:50 GMT
Subject: Re: [PATCH] builtin-clone: fix for new unpack_trees() semantics
Message-ID: <alpine.LSU.1.00.0803101157300.3975@racer.site>
In-Reply-To: <alpine.LNX.1.00.0803091911010.19665@iabervon.org>

Hi,

On Sun, 9 Mar 2008, Daniel Barkalow wrote:

> On Mon, 10 Mar 2008, Johannes Schindelin wrote:
> 
> > Yes.  And this sets dst_index (what I tried to hint at with my patch).
> 
> Oh, yes. Your patch is what prompted me to fix that part (and to find 
> that Linus's unpack_trees was in next now). But seeing src_index in your 
> patch made me wonder what it wanted a source index for anyway, since 
> this is the first index we've had in this repo.

Well, stupid copy-'n-paste.  Well, not all that stupid: because of the 
twoway_merge (and because the segmentation fault was in a line accessing 
src_index), I assumed that the src_index is needed.

But your explanation that oneway_merge is all we want makes tons of sense.

Ciao,
Dscho