Re: [PATCH 2/2] Add support for host aliases in config files

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 20, 2008, 01:01 UTC
Message-ID: <alpine.LSU.1.00.0802200156560.8333@wbgn129.biozentrum.uni-wuerzburg.de>
In-Reply-To: <alpine.LNX.1.00.0802191856420.19024@iabervon.org>

Hi,

On Tue, 19 Feb 2008, Daniel Barkalow wrote:

Show 8 quoted lines

> On Tue, 19 Feb 2008, Junio C Hamano wrote:
> 
> > Either your '[host "$this_url"] aka = $that_url' or
> > Dscho's earlier '[rewrite "$this_url_to"] url = $that_url' shows
> > that this is not about host but "prefix part of URL".
> 
> Well, it shows that it's *possible* to do this feature that way, 
> although I'm not entirely convinced that it's best to do it like that.

I think in the interest of simplicity, you do not want to have an extra (arbitrary) key.

> Are there character set concerns with having urls in config keys?

I think not. AFAICT the "extended base var" is allowed anything except for newlines. Everything else you can get at least escaped with '\'. If in doubt, consult get_extended_base_var() in config.c.

Hth, Dscho