Re: [PATCH 2/2] Add support for host aliases in config files

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Feb 20, 2008, 00:02 UTC
Message-ID: <alpine.LNX.1.00.0802191856420.19024@iabervon.org>
In-Reply-To: <7vy79ghbob.fsf@gitster.siamese.dyndns.org>

On Tue, 19 Feb 2008, Junio C Hamano wrote:

Show 17 quoted lines

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > On Tue, 19 Feb 2008, Jon Loeliger wrote:
> >
> >> Also, is "host" really the right config key?  Maybe "rewritehost"?
> >> Or is this thought to be the basis of other (perhaps not rewrite
> >> related) properties of the same host as well?
> >
> > I think it's likely that other properties of the host could show up. I 
> > suspect that uploadpack and receivepack would be useful host-wide if you 
> > were using a lot of ad-hoc repository names on a big site. Rewriting the 
> > URLs is just the itch I had with this scope.
> 
> I'd agree that per-host configuration may be useful, and your
> "paths to programs" may be a good example.  But I think it is
> plausible that a host needs multiple <rewritefrom,rewriteto>
> tuples.

That's probably true, even taking into account the option of having multiple froms for the same to.

> Either your '[host "$this_url"] aka = $that_url' or
> Dscho's earlier '[rewrite "$this_url_to"] url = $that_url' shows
> that this is not about host but "prefix part of URL".

Well, it shows that it's *possible* to do this feature that way, although I'm not entirely convinced that it's best to do it like that. Are there character set concerns with having urls in config keys?

	-Daniel
*This .sig left intentionally blank*