git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] branch: optionally setup branch.*.merge from upstream local branches

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 19, 2008, 16:45 UTC
Message-ID
<alpine.LSU.1.00.0802191643490.30505@racer.site>
In-Reply-To
<1203438278-73786-1-git-send-email-jaysoffian@gmail.com>
Hi,
On Tue, 19 Feb 2008, Jay Soffian wrote:
Show 8 quoted lines
> +	if (!tracking.matches)
> +		switch (track) {
> +		case BRANCH_TRACK_ALWAYS:
> +		case BRANCH_TRACK_EXPLICIT:
> +			break;
> +		default:
> +			return 1;
> +		}
I'd write that as
	if (!tracking.matches &&
	    (track == BRANCH_TRACK_ALWAYS || track == BRANCH_TRACK_EXPLICIT))
		return 1;
but that is really niggling about style...
As you can see, I have no real objections ;-)

Ciao, Dscho

Previous: Jay Soffian
Message 6 of 6 in “branch: optionally setup branch.*.merge from upstream local branches”
  1. 1/2 branch: optionally setup branch.*.merge from upstream local branchesJay Soffian, Feb 19, 2008
  2. 2/2 doc: documentation update for the branch track changesJay Soffian, Feb 19, 2008
  3. Junio C HamanoFeb 19, 2008
  4. Jay SoffianFeb 19, 2008
  5. Jay SoffianFeb 19, 2008
  6. Johannes SchindelinFeb 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.