From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 19 Feb 2008 16:45:22 GMT
Subject: Re: [PATCH 1/2] branch: optionally setup branch.*.merge from upstream local branches
Message-ID: <alpine.LSU.1.00.0802191643490.30505@racer.site>
In-Reply-To: <1203438278-73786-1-git-send-email-jaysoffian@gmail.com>

Hi,

On Tue, 19 Feb 2008, Jay Soffian wrote:

> +	if (!tracking.matches)
> +		switch (track) {
> +		case BRANCH_TRACK_ALWAYS:
> +		case BRANCH_TRACK_EXPLICIT:
> +			break;
> +		default:
> +			return 1;
> +		}

I'd write that as

	if (!tracking.matches &&
	    (track == BRANCH_TRACK_ALWAYS || track == BRANCH_TRACK_EXPLICIT))
		return 1;

but that is really niggling about style...

As you can see, I have no real objections ;-)

Ciao,
Dscho