git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] http-push fixes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 14, 2008, 23:25 UTC
Message-ID
<alpine.LSU.1.00.0802142319340.30505@racer.site>
Hi,

I have to admit that impatience got the better part of me. So I did not wait for those promised http cleanups, but dived into the current code and debugged a (failing) http-push for several hours.

Let me tell this: http-push's source code is not nice. The code is hard to follow, and it is repetitive. I would really welcome a major cleanup, but unfortunately, I do not have half the time I would need for this.

So here go three patches, the first two of them fixing real issues (a segfault, and an "out of memory", which is not really one), and the last showing just what kind of cruft needs removing in http-push.c.

I'm particularly bad with cover-letters (waiting for format-patch --cover-letter to be applied, hint, hint), so this is my version of one:

 http-push.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

Ciao, Dscho

Next: Johannes Schindelin
Message 1 of 8 in “http-push fixes”
  1. 0/3 http-push fixesJohannes Schindelin, Feb 14, 2008
  2. 1/3 http-push: avoid invalid memory accessesJohannes Schindelin, Feb 14, 2008
  3. Junio C HamanoFeb 16, 2008
  4. Mike HommeyFeb 16, 2008
  5. Johannes SchindelinFeb 16, 2008
  6. 2/3 http-push: do not get confused by submodulesJohannes Schindelin, Feb 14, 2008
  7. 2/3 http-push: do not get confused by submodulesJohannes Schindelin, Feb 14, 2008
  8. 3/3 http-push: avoid a needless gotoJohannes Schindelin, Feb 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.