Re: [PATCH] prune: heed --expire for stale packs, add a test
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 6, 2008, 07:41 UTC
- Message-ID
- <alpine.LSU.1.00.0802060741380.8543@racer.site>
- In-Reply-To
- <7v7ihi64xm.fsf@gitster.siamese.dyndns.org>
Hi,
On Tue, 5 Feb 2008, Junio C Hamano wrote:
Show 24 quoted lines
> Nicolas Pitre <nico@cam.org> writes: > > > On Tue, 5 Feb 2008, Johannes Schindelin wrote: > > > >> Follow the same logic as for loose objects when removing stale packs: they > >> might be in use (for example when fetching, or repacking in a cron job), > >> so give the user a chance to say (via --expire) what is considered too > >> young an age to die for stale packs. > >> > >> Also add a simple test to verify that the stale packs are actually > >> expired. > >> > >> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > Acked-by: Nicolas Pitre <nico@cam.org> > > > > Nicolas > > They are not "stale packs", but temporary files that wanted to > become pack but did not succeed. Perhaps "stale temporary > packs"? > > Shouldn't we do something similar to objects/pack/pack-*.temp > files and objects/??/*.temp that http walker leaves?
Yep.
Ciao, Dscho