Re: [PATCH] Make git prune remove temporary packs that look like write failures
- From
Nicolas Pitre <nico@cam.org>
- Date
- Feb 6, 2008, 20:07 UTC
- Message-ID
- <alpine.LFD.1.00.0802061505390.2732@xanadu.home>
- In-Reply-To
- <e1dab3980802061157r36dfa8b9uab49af013cb8e963@mail.gmail.com>
On Wed, 6 Feb 2008, David Tweed wrote:
> Given I'm the only person (AFAICS from the list archives) who's ever > talked about failed temporary packs, I assume that almost everyone > using git is using filesystems with sufficient space that they don't > get write errors,
Note that doing ^C during a fetch will also leave a temporary pack file there. So your patch is good even for people with plenty of disk space.
> so the path building will generally be done 0 times > per --prune. (Using a USB disk that's almost full, along with > occasionally filling up my /home with experiment output, is the > occasions I get them.) So I don't think efficiency is an issue.
Clearly not a hot path indeed.
Nicolas