git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Use config file or file for repository owner's name.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 31, 2008, 11:12 UTC
Message-ID
<alpine.LSU.1.00.0801311110280.23907@racer.site>
In-Reply-To
<m3bq728y4o.fsf@localhost.localdomain>
Hi,
On Wed, 30 Jan 2008, Jakub Narebski wrote:
Show 37 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Junio C Hamano <gitster@pobox.com> writes:
> > 
> >> Bruno Cesar Ribas <ribas@c3sl.ufpr.br> writes:
> >> ...
> >>> Opening the extra file has same problem as the description file. 
> >>> And, as gitweb allow us to create "description" and "cloneurl" file 
> >>> there is no problem having another file to open instead finding out 
> >>> who is the owner of the directory asking to the filesystem.
> >>
> >> We heard the same argument when cloneurl was added, and a newcomer 
> >> who does not know that may rightly use the same argument.  But I 
> >> think we should work towards _reducing_ the number of such ad-hoc 
> >> one-line-per-information files, not using existing ones as an excuse 
> >> to add _more_ of them.
> > 
> > Rephrasing to be constructive (but remember, this is all post 1.5.4).
> > 
> >  * we would need for historical reasons to keep supporting
> >    description and cloneurl for some time.  There may be some
> >    others, but the goal should be to deprecate and remove these
> >    ad-hoc one-file-per-piece-of-information files.
> > 
> >  * we also need for historical reasons to keep supporting some
> >    other stuff found in $git_dir/config of the project.
> > 
> > If the config reading interface in gitweb is reasonably fast and 
> > cheap, we can move the existing description/cloneurl to gitweb config 
> > when deprecating them.  New ones such as "owner" would naturally fit 
> > there.
> 
> Currently gitweb parses repo config file _once_, using one call to 
> git-config -z -l.
> 
> We could simply add description to the projects_list file, but it will 
> be a bit backwards incompatibile change.

Not if you say "the config overrides the description/cloneurl file", i.e. when there is a description or a cloneurl from the config, don't even bother to stat the single-line files.

That would help transition, and still be backwards compatible. (BTW this resembles what we did for the .git/remotes/* -> .git/config transition.)

Ciao, Dscho

Previous: Jakub NarebskiNext: Jakub Narebski
Message 9 of 16 in “gitweb: Use config file or file for repository owner's name.”
  1. gitweb: Use config file or file for repository owner's name.Bruno Ribas, Jan 30, 2008
  2. gitweb: Update gitweb/README to include the new per-repository configurationBruno Ribas, Jan 30, 2008
  3. Junio C HamanoJan 30, 2008
  4. Bruno Cesar RibasJan 31, 2008
  5. Junio C HamanoJan 31, 2008
  6. Bruno Cesar RibasJan 31, 2008
  7. Junio C HamanoJan 31, 2008
  8. Jakub NarebskiJan 31, 2008
  9. Johannes SchindelinJan 31, 2008
  10. Jakub NarebskiFeb 1, 2008
  11. Bruno Cesar RibasFeb 4, 2008
  12. Jakub NarebskiFeb 4, 2008
  13. Bruno Cesar RibasFeb 5, 2008
  14. Jakub NarebskiFeb 5, 2008
  15. Bruno Cesar RibasFeb 5, 2008
  16. Bruno Cesar RibasFeb 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.