Re: [PATCH] gitweb: Use config file or file for repository owner's name.
- From
- Bruno Cesar Ribas <ribas@c3sl.ufpr.br>
- Date
- Jan 31, 2008, 03:02 UTC
- Message-ID
- <20080131030250.GA10011@c3sl.ufpr.br>
- In-Reply-To
- <7vsl0eg16c.fsf@gitster.siamese.dyndns.org>
On Wed, Jan 30, 2008 at 06:48:43PM -0800, Junio C Hamano wrote:
Show 19 quoted lines
> Bruno Cesar Ribas <ribas@c3sl.ufpr.br> writes: > > > On Tue, Jan 29, 2008 at 10:16:16PM -0800, Junio C Hamano wrote: > >> Bruno Ribas <ribas@c3sl.ufpr.br> writes: > >> > >> <snip> > >> I am not sure about the effect of this change on a large scale > >> site. If you do not have the project list file, originally we > >> just needed a stat per project, but now you open an extra file > >> (either "owner" or "config") and read it, once per every > >> project. > > > > Opening the extra file has same problem as the description file. And, as > > gitweb allow us to create "description" and "cloneurl" file there is no > > problem having another file to open instead finding out who is the owner of > > the directory asking to the filesystem. > > We heard the same argument when cloneurl was added, and a > newcomer who does not know that may rightly use the same
Well, it worked for cloneurl.
> argument. But I think we should work towards _reducing_ the > number of such ad-hoc one-line-per-information files, not using > existing ones as an excuse to add _more_ of them.
Okay, I agree with you. We need to centralize information. One idea use $GIT_DIR/config only, sharing any other information. But I don't like the idea do parse $GIT_DIR/config everytime. Unless it caches gitweb only information in one line.
Another Idea is to use $GIT_DIR/gitweb.conf with information [like the cached above], but generated by the gitweb admin.
Other to continue with all those files, but creating a gitweb.d/* .
That's what I can think 1:02am =(
Good night
-- Bruno Ribas - ribas@c3sl.ufpr.br http://web.inf.ufpr.br/ribas C3SL: http://www.c3sl.ufpr.br