git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-commit: add a prepare-commit-msg hook

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 21, 2008, 11:04 UTC
Message-ID
<alpine.LSU.1.00.0801211101450.5731@racer.site>
In-Reply-To
<479438D1.2050107@gnu.org>
Hi,
On Mon, 21 Jan 2008, Paolo Bonzini wrote:
> I would like to understand why both of you have not considered the point 
> that the script would need the updated index from git-commit.

I have. But I want to avoid a regression at any cost. And your patch just looks to me like it could do that.

But it _has_ been already suggested that you could provide arguments for the existing msg-hook, which would not break anything, since the hook does not get any argument yet, and therefore existing hooks would be unaffected.

Also, the change would be non-intrusive, easy-to-review, and it would not take so much time away from the bug-fixing that we want to do right now in the rc-cycle.

Okay? Dscho

Previous: Paolo BonziniNext: Paolo Bonzini
Message 19 of 23 in “git-commit: add a prepare-commit-msg hook”
  1. git-commit: add a prepare-commit-msg hookPaolo Bonzini, Jan 18, 2008
  2. Johannes SchindelinJan 18, 2008
  3. Paolo BonziniJan 18, 2008
  4. Johannes SchindelinJan 18, 2008
  5. Paolo BonziniJan 18, 2008
  6. Johannes SchindelinJan 18, 2008
  7. Paolo BonziniJan 18, 2008
  8. Benoit SigoureJan 18, 2008
  9. Alex RiesenJan 18, 2008
  10. Paolo BonziniJan 18, 2008
  11. Alex RiesenJan 18, 2008
  12. Junio C HamanoJan 18, 2008
  13. Paolo BonziniJan 19, 2008
  14. Johannes SchindelinJan 19, 2008
  15. Benoit SigoureJan 19, 2008
  16. Paolo BonziniJan 19, 2008
  17. Junio C HamanoJan 20, 2008
  18. Paolo BonziniJan 21, 2008
  19. Johannes SchindelinJan 21, 2008
  20. Paolo BonziniJan 21, 2008
  21. Johannes SchindelinJan 21, 2008
  22. Paolo BonziniJan 21, 2008
  23. Junio C HamanoJan 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.