Re: [PATCH] git-commit: add a prepare-commit-msg hook

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jan 18, 2008, 21:08 UTC
Message-ID: <20080118210825.GB3411@steel.home>
In-Reply-To: <47910229.90700@gnu.org>

Paolo Bonzini, Fri, Jan 18, 2008 20:46:49 +0100:

Show 11 quoted lines

> Alex Riesen wrote:
>> Paolo Bonzini, Fri, Jan 18, 2008 15:51:25 +0100:
>>> +		if (!edit_message) {
>>> +			run_hook(index_file, "prepare-commit-msg", git_path(commit_editmsg));
>>> +		}
>>>  		launch_editor(git_path(commit_editmsg), NULL, env);
>> "preedit-new-commit-msg", perhaps. A "prepare-" suggests it is called
>> every time, even if no editor is specified, which it is not.
>> And it really does look like a template...
>
> It is, but quite a powerful one. :-)

Except that "template" is already taken. Someone uses it and some may even got used to "template" having that meaning.

> template-commit-msg?

Not really. It will be run even if the template (the one Git have already) is not used.

It really looks a bit complicated. If at all, how about running that "pre-editor" hook with information about where the message comes from?

I.e. if the message comes from a template:

    preedit-commit-msg .git/COMMIT_MSG template

or, for a message coming from commit:

    preedit-commit-msg .git/COMMIT_MSG commit 0123456789abdef

or, for a message coming from a file

    preedit-commit-msg .git/COMMIT_MSG file user/path/to/file

and finally, for a new message:

    preedit-commit-msg .git/COMMIT_MSG