git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-fsck: report missing author/commit line in a commit as an error

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 20, 2008, 19:20 UTC
Message-ID
<alpine.LSU.1.00.0801201918260.5731@racer.site>
In-Reply-To
<12008555922208-git-send-email-mkoegler@auto.tuwien.ac.at>
Hi,
On Sun, 20 Jan 2008, Martin Koegler wrote:
> +	if (!commit->date)
> +		return objerror(&commit->object, "invalid author/commiter line in %s",
s/commiter/committer/

It makes me wonder, though, if that's correct. AFAICT it is the committer date, and the rest of the line _might_ be just fine.

Why not be less intrusive and just change the printf() into a return objerror(), like the commit message suggests?

Ciao, Dscho

Previous: Martin KoeglerNext: Martin Koegler
Message 2 of 3 in “git-fsck: report missing author/commit line in a commit as an error”
  1. git-fsck: report missing author/commit line in a commit as an errorMartin Koegler, Jan 20, 2008
  2. Johannes SchindelinJan 20, 2008
  3. Martin KoeglerJan 21, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.